c++ - How do I make this program smaller, more efficient? -


i doing practice question went this:

write program asks user enter number of hamburgers eaten ten different people (p1, p2, ... etc.)

once data has been entered program must analyze data , output person ate least hamburgers, , outputs person ate hamburgers.

i know code isn't ideal(to least, determined finish have go off of question. if you're willing help, don't afraid throw more complex things @ me, that's how learn, right?

here's code:

#include <iostream>   #include <string>   using namespace std;  int main() {     int p1 = 0;      int p2 = 0;      int p3 = 0;      int p4 = 0;      int p5 = 0;      int p6 = 0;      int p7 = 0;      int p8 = 0;      int p9 = 0;      int p10 = 0;       cout << "how many pancakes did p1 eat?" << endl;     cin >> p1;      cout << "how many pancakes did p2 eat?" << endl;     cin >> p2;      cout << "how many pancakes did p3 eat?" << endl;     cin >> p3;      cout << "how many pancakes did p4 eat?" << endl;     cin >> p4;      cout << "how many pancakes did p5 eat?" << endl;     cin >> p5;      cout << "how many pancakes did p6 eat?" << endl;     cin >> p6;      cout << "how many pancakes did p7 eat?" << endl;     cin >> p7;      cout << "how many pancakes did p8 eat?" << endl;     cin >> p8;      cout << "how many pancakes did p9 eat?" << endl;     cin >> p9;      cout << "how many pancakes did p10 eat?" << endl;     cin >> p10;       // large section of if statements incoming       // test see person ate least pancakes      if (p1 < p2 && p1 < p3 && p1 < p4 && p1 < p5 && p1 < p6 && p1 < p7 && p1 < p8 && p1 < p9 && p1 < p10)     {         cout << "p1 ate least pancakes." << endl;     }      if (p2 < p1 && p2 < p3 && p2 < p4 && p2 < p5 && p2 < p6 && p2 < p7 && p2 < p8 && p2 < p9 && p2 < p10)     {         cout << "p2 ate least pancakes." << endl;     }      if (p3 < p1 && p3 < p2 && p3 < p4 && p3 < p5 && p3 < p6 && p3 < p7 && p3 < p8 && p3 < p9 && p3 < p10)     {         cout << "p3 ate least pancakes." << endl;     }      if (p4 < p1 && p4 < p2 && p4 < p3 && p4 < p5 && p4 < p6 && p4 < p7 && p4 < p8 && p4 < p9 && p4 < p10)     {         cout << "p4 ate least pancakes." << endl;     }      if (p5 < p1 && p5 < p2 && p5 < p3 && p5 < p4 && p5 < p6 && p5 < p7 && p5 < p8 && p5 < p9 && p5 < p10)     {         cout << "p5 ate least pancakes." << endl;     }      if (p6 < p1 && p6 < p2 && p6 < p3 && p6 < p4 && p6 < p5 && p6 < p7 && p6 < p8 && p6 < p9 && p6 < p10)     {         cout << "p6 ate least pancakes." << endl;     }      if (p7 < p1 && p7 < p2 && p7 < p3 && p7 < p4 && p7 < p5 && p7 < p6 && p7 < p7 && p7 < p9 && p7 < p10)     {         cout << "p7 ate least pancakes." << endl;     }      if (p8 < p1 && p8 < p2 && p8 < p3 && p8 < p4 && p8 < p5 && p8 < p6 && p8 < p7 && p8 < p9 && p8 < p10)     {         cout << "p8 ate least pancakes." << endl;     }      if (p9 < p1 && p9 < p2 && p9 < p3 && p9 < p4 && p9 < p5 && p9 < p6 && p9 < p7 && p9 < p8 && p9 < p10)     {         cout << "p9 ate least pancakes." << endl;     }      if (p10 < p1 && p10 < p2 && p10 < p3 && p10 < p4 && p10 < p5 && p10 < p6 && p10 < p7 && p10 < p8 && p10 < p9)     {         cout << "p10 ate least pancakes." << endl;     }       // test see ate pancakes      if (p1 > p2 && p1 > p3 && p1 > p4 && p1 > p5 && p1 > p6 && p1 > p7 && p1 > p8 && p1 > p9 && p1 > p10)     {         cout << "p1 ate pancakes." << endl;     }      if (p2 > p1 && p2 > p3 && p2 > p4 && p2 > p5 && p2 > p6 && p2 > p7 && p2 > p8 && p2 > p9 && p2 > p10)     {         cout << "p2 ate pancakes." << endl;     }      if (p3 > p1 && p3 > p2 && p3 > p4 && p3 > p5 && p3 > p6 && p3 > p7 && p3 > p8 && p3 > p9 && p3 > p10)     {         cout << "p3 ate pancakes." << endl;     }      if (p4 > p1 && p4 > p2 && p4 > p3 && p4 > p5 && p4 > p6 && p4 > p7 && p4 > p8 && p4 > p9 && p4 > p10)     {         cout << "p4 ate pancakes." << endl;     }      if (p5 > p1 && p5 > p2 && p5 > p3 && p5 > p4 && p5 > p6 && p5 > p7 && p5 > p8 && p5 > p9 && p5 > p10)     {         cout << "p5 ate pancakes." << endl;     }      if (p6 > p1 && p6 > p2 && p6 > p3 && p6 > p4 && p6 > p5 && p6 > p7 && p6 > p8 && p6 > p9 && p6 > p10)     {         cout << "p6 ate pancakes." << endl;     }      if (p7 > p1 && p7 > p2 && p7 > p3 && p7 > p4 && p7 > p5 && p7 > p6 && p7 > p7 && p7 > p9 && p7 > p10)     {         cout << "p7 ate pancakes." << endl;     }      if (p8 > p1 && p8 > p2 && p8 > p3 && p8 > p4 && p8 > p5 && p8 > p6 && p8 > p7 && p8 > p9 && p8 > p10)     {         cout << "p8 ate pancakes." << endl;     }      if (p9 > p1 && p9 > p2 && p9 > p3 && p9 > p4 && p9 > p5 && p9 > p6 && p9 > p7 && p9 > p8 && p9 > p10)     {         cout << "p9 ate pancakes." << endl;     }      if (p10 > p1 && p10 > p2 && p10 > p3 && p10 > p4 && p10 > p5 && p10 > p6 && p10 > p7 && p10 > p8 && p10 > p9)     {         cout << "p10 ate pancakes." << endl;     }       return 0; }

vector of pancake quantities

try this:

typedef std::vector<unsigned int> pancake_container; const unsigned int maximum_participants = 10; pancake container pancake_quantities(maximum_participants); (unsigned int = 0u; < maximum_participants; ++i) {   static const char prompt_text1[] = "\nhow many pancakes did participant #";   static const char prompt_ending[] = " eat? ";   cout.write(prompt_text1, sizeof(prompt_text1) - 1u);   cout << i;   cout.write(prompt_ending, sizeof(prompt_ending) - 1u));   unsigned int quantity = 0u;   cin >> quantity;   pancake_quantities[i] = quantity; }  unsigned int max_person_index = 0u; unsigned int max_pancakes_eaten = 0u; unsigned int min_person_index = 0u; unsigned int min_pancakes_eaten = max_uint; (unsigned int = 0u; < maximum_participants; ++i) {   const unsigned int quantity = pancake_quantities[i];   if (quantity > max_pancakes_eaten)   {     max_person_index = i;     max_pancakes_eaten = quantity;   }   if (quantity < min_pancakes_eaten)   {     min_person_index = i;     min_pancakes_eaten = quantity;   } }  cout << "person #" << max_person_index << " ate " << max_pancakes_eaten << "\n"; cout << "person #" << min_person_index << " ate " << min_pancakes_eaten << "\n";

vector of structures

this 1 allows sorting figure out maximum , minimum.

struct pancake_info {     unsigned int id;     unsigned int quantity;     pancake_info() : id(0), quantity(0)         {}     bool operator < (const pancake_info& other)         {             return quantity < other.quantity;         } };  typedef std::vector<pancake_info> pancake_container; pancake_container pancake_quantities; (unsigned int = 0u; < maximum_participants; ++i) {     static const char prompt_text1[]  = "\nhow many pancakes did participant #";     static const char prompt_ending[] = " eat? ";     cout.write(prompt_text1, sizeof(prompt_text1) - 1u);     cout << i;     cout.write(prompt_ending, sizeof(prompt_ending) - 1u);     unsigned int quantity = 0u;     pancake_info p_i;     cin >> p_i.quantity;     p_i.id = i;     pancake_quantities.push_back(p_i); } std::sort(pancake_quantities.begin(), pancake_quantities.end()); cout << "minimum of "      << pancake_quantities[0].quantity      << " eaten person "      << pancake_quantities[0].id      << "\n"; cout << "maximum of "      << pancake_quantities[maximum_participants - 1].quantity      << " eaten person "      << pancake_quantities[maximum_participants - 1].id      << "\n";

-

Comments

Post a Comment

Popular posts from this blog

apache - PHP Soap issue while content length is larger -

we have developed soap based webservice post data third party webservice. accepts 4 params. in 1 of parameters accepts xml string no size limit restriction put in place. the webservice works fine in local environment running on php 5.2 , apache2. works content length long 10 mb. in staging server running nginx , php fpm.we have updated max post size , max upload filesize in php.ini , client_max_body param in nginx.conf allow upto 50 mb. but webservice client keeps on loading in staging environment. gives 502 timeout , gives soap error. can me understand issue here?
Read more

asynchronous - Python asyncio task got bad yield -

i confused how play around asyncio module in python 3.4. have searching api search engine, , want each search request run either parallel, or asynchronously, don't have wait 1 search finish start another. here high-level searching api build objects raw search results. search engine using kind of asyncio mechanism, won't bother that. # no asyncio module used here class search(object): ... self.s = some_search_engine() ... def searching(self, *args, **kwargs): ret = {} # raw searching according args , kwargs , build wrapped results ... return ret to try async requests, wrote following test case test how can interact stuff asyncio module. # here testing script @asyncio.coroutine def handle(f, *args, **kwargs): r = yield f(*args, **kwargs) return r s = search() loop = asyncio.get_event_loop() loop.run_until_complete(handle(s.searching, arg1, arg2, ...)) loop.close() by running pytest, return runtimeerror: task got bad yield : {results s...
Read more

javascript - Complete OpenIDConnect auth when requesting via Ajax -

the normal openidconnect server works like: you go a.com/secure-resource you 302 server your browser handles , sends identity server you login there it sends a.com via post you logged in on a.com , a.com/secure-resource on browser. however have scenario i'm trying solve need help. the user logged in on idserver the user logged in on a.com the user not logged in on b.com we need send ajax call web server b.com (from domain a.com ) b.com configured use openidconnect. but because request b.com via ajax, user cannot redirected idserver. (all in response 302 ) we can go ahead , handle 302 via ajax (i'm still not sure whether work, security-wise). but is there scenario in identityserver/openidconnect designed these situations? with identityserver in scenario setup server b.com use bearer token authentication, need use access token provided a.com in headers of ajax call $.ajax({ url: 'http://b.com', headers: { ...
Read more